Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rubocop check to CI #106

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Add rubocop check to CI #106

merged 3 commits into from
Jul 9, 2024

Conversation

benk-gc
Copy link
Contributor

@benk-gc benk-gc commented Jul 6, 2024 •
edited
Loading

Although we have rubocop available we never actually run it as part of the CI workflow, and as a result errors can creep in as new code is committed. This adds a CI linting check, and fixes all existing errors.

@benk-gc benk-gc force-pushed the benk--apply-rubocop branch 3 times, most recently from 7f07215 to 33dd034 Compare July 6, 2024 22:05
stephenbinns
stephenbinns reviewed Jul 8, 2024
View reviewed changes
Gemfile Outdated Show resolved Hide resolved
@benk-gc benk-gc force-pushed the benk--apply-rubocop branch from 33dd034 to 4c33d68 Compare July 9, 2024 09:44
@benk-gc benk-gc changed the title Add rubocop to CI Add rubocop check to CI Jul 9, 2024
@benk-gc benk-gc force-pushed the benk--apply-rubocop branch from 4c33d68 to 684768e Compare July 9, 2024 09:48
@benk-gc benk-gc marked this pull request as ready for review July 9, 2024 09:50
Tabby
Tabby reviewed Jul 9, 2024
View reviewed changes
.github/workflows/tests.yml Outdated Show resolved Hide resolved
Tabby
Tabby approved these changes Jul 9, 2024
View reviewed changes
Copy link

@Tabby Tabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reckon some of these disabled checks in various files could be fixed, but on the whole this looks good to me and it's probably not worth the effort of doing so right now :)

benk-gc added 3 commits July 9, 2024 11:33
@benk-gc
Add GitHub action to run rubocop.
67a343e
@benk-gc
Fix rubocop violations.
ee6633a
@benk-gc
Update .ruby-version to 3.0.7.
77482aa 
Fixes an annoying issue with rubygems which spams warnings when running
certain commands.

See rubygems/rubygems#5016
@benk-gc benk-gc force-pushed the benk--apply-rubocop branch from 684768e to 77482aa Compare July 9, 2024 10:33
@benk-gc benk-gc merged commit cfb84d4 into master Jul 9, 2024
5 of 6 checks passed
@benk-gc benk-gc deleted the benk--apply-rubocop branch July 9, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenbinns stephenbinns stephenbinns left review comments

@Tabby Tabby Tabby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benk-gc @stephenbinns @Tabby